Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-12-15 00:28:58 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

ExtraFileHash check for integer overflow

Browse source 
When passing large periods 2038 problems was silently triggered due to
  time being stored as int in FileInfo::age, thus causing erratic
  behaviour in extra files timeout. Now period is checked and if too
  large an error is reported.
Deprecate FileDetails which is confusing dummy wrapper of FileInfo
Remove ftExtraList::cleanupEntry deadcode
This commit is contained in:
Gioacchino Mazzurco 2020-05-31 15:19:00 +02:00
parent 54364c488e
commit 295ecf368e
No known key found for this signature in database
GPG key ID: A1FBCA3872E87051
4 changed files with 46 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

3
libretroshare/src/retroshare/rsfiles.h
View file

@ -658,7 +658,8 @@ public:
* @brief Get file details
* @jsonapi{development}
* @param[in] hash file identifier
* @param[in] hintflags filtering hint (RS_FILE_HINTS_EXTRA|...|RS_FILE_HINTS_LOCAL)
* @param[in] hintflags filtering hint ( RS_FILE_HINTS_UPLOAD|...|
* RS_FILE_HINTS_EXTRA|RS_FILE_HINTS_LOCAL )
* @param[out] info storage for file information
* @return true if file found, false otherwise
*/