replaced QString output of uniqueIdentifier() in feedItem classes by a std::string because QString caused random crashes

libretroshare/src/services/p3rtt.cc

@@ -442,6 +442,7 @@ bool RttPeerInfo::initialisePeerInfo(const RsPeerId& id)
 	mCurrentPingTS = 0;
 	mCurrentPingCounter = 0;
 	mCurrentPongRecvd = true;
+	mCurrentMeanOffset = 0;
 
 	mSentPings = 0;
 	mLostPongs = 0;

libretroshare/src/services/p3rtt.h

@@ -34,6 +34,8 @@ class p3ServiceControl;
 class RttPeerInfo
 {
 	public:
+    RttPeerInfo()
+        : mCurrentPingTS(0.0),mCurrentPingCounter(0.0),mCurrentPongRecvd(false),mCurrentMeanOffset(0.0),mLostPongs(0),mSentPings(0){}
 
 	bool initialisePeerInfo(const RsPeerId& id);
 

retroshare-gui/src/gui/Posted/PostedItem.h

@@ -49,7 +49,7 @@ public:
 	const RsPostedPost &getPost() const;
 	RsPostedPost &post();
 
-	QString uniqueIdentifier() const override { return "PostedItem " + QString::fromStdString(mMessageId.toStdString()); }
+	std::string uniqueIdentifier() const override { return "PostedItem " + mMessageId.toStdString(); }
 protected:
 	/* FeedItem */
 	virtual void doExpand(bool open);

retroshare-gui/src/gui/common/RSFeedWidget.cpp

@@ -476,10 +476,10 @@ void RSFeedWidget::withAll(RSFeedWidgetCallbackFunction callback, void *data)
 	}
 }
 
-FeedItem *RSFeedWidget::findFeedItem(const QString& identifier)
+FeedItem *RSFeedWidget::findFeedItem(const std::string& identifier)
 {
 	QTreeWidgetItemIterator it(ui->treeWidget);
-	QTreeWidgetItem *treeItem;
+	QTreeWidgetItem *treeItem=NULL;
 
     // this search could probably be automatised by giving the tree items the identifier as data for some specific role, then calling QTreeWidget::findItems()
 #warning TODO

retroshare-gui/src/gui/common/RSFeedWidget.h

@@ -71,7 +71,7 @@ public:
 	bool scrollTo(FeedItem *feedItem, bool focus);
 
 	void withAll(RSFeedWidgetCallbackFunction callback, void *data);
-	FeedItem *findFeedItem(const QString &identifier);
+	FeedItem *findFeedItem(const std::string &identifier);
 
 	void selectedFeedItems(QList<FeedItem*> &feedItems);
 

retroshare-gui/src/gui/feeds/ChatMsgItem.h

@@ -37,7 +37,7 @@ public:
 
 	void updateItemStatic();
 
-    virtual QString uniqueIdentifier() const override { return "ChatMsgItem " + QString::fromStdString(mPeerId.toStdString()) ;}
+    virtual std::string uniqueIdentifier() const override { return "ChatMsgItem " + mPeerId.toStdString(); }
 protected:
 	/* FeedItem */
 	virtual void doExpand(bool /*open*/) {}

retroshare-gui/src/gui/feeds/FeedItem.h

@@ -41,7 +41,7 @@ public:
      * \return returns a string that is unique to this specific item. The string will be used to search for an existing item that
      * 			would contain the same information. It should therefore sumarise the data represented by the item.
      */
-    virtual QString uniqueIdentifier() const =0;
+    virtual std::string uniqueIdentifier() const =0;
 protected:
 	virtual void doExpand(bool open) = 0;
 	virtual void expandFill(bool /*first*/) {}

retroshare-gui/src/gui/feeds/GxsChannelGroupItem.h

@@ -42,7 +42,7 @@ public:
 
 	bool setGroup(const RsGxsChannelGroup &group);
 
-    QString uniqueIdentifier() const override { return "GxsChannelGroupItem " + QString::fromStdString(mGroup.mMeta.mGroupId.toStdString()) ; }
+    std::string uniqueIdentifier() const override { return "GxsChannelGroupItem " + mGroup.mMeta.mGroupId.toStdString() ; }
 protected:
 	/* FeedItem */
 	virtual void doExpand(bool open);

retroshare-gui/src/gui/feeds/GxsChannelPostItem.h

@@ -53,7 +53,7 @@ public:
 	//GxsChannelPostItem(FeedHolder *feedHolder, uint32_t feedId, const RsGxsChannelPost &post, bool isHome, bool autoUpdate);
 	virtual ~GxsChannelPostItem();
 
-    virtual QString uniqueIdentifier() const override { "GxsChannelPostItem " + QString::fromStdString(mPost.mMeta.mMsgId.toStdString()) ; }
+    virtual std::string uniqueIdentifier() const override { "GxsChannelPostItem " + mPost.mMeta.mMsgId.toStdString() ; }
 
 	bool setGroup(const RsGxsChannelGroup &group, bool doFill = true);
 	bool setPost(const RsGxsChannelPost &post, bool doFill = true);

retroshare-gui/src/gui/feeds/GxsCircleItem.cpp

@@ -167,9 +167,9 @@ void GxsCircleItem::setup()
 
 }
 
-QString GxsCircleItem::uniqueIdentifier() const
+std::string GxsCircleItem::uniqueIdentifier() const
 {
-    return "GxsCircle " + QString::fromStdString(mCircleId.toStdString()) + " " + QString::fromStdString(mGxsId.toStdString()) + " " + QString::number(mType);
+    return "GxsCircle " + mCircleId.toStdString() + " " + mGxsId.toStdString() + " " + QString::number(mType).toStdString();
 }
 
 void GxsCircleItem::removeItem()

retroshare-gui/src/gui/feeds/GxsCircleItem.h

@@ -52,7 +52,7 @@ public:
 	GxsCircleItem(FeedHolder *feedHolder, uint32_t feedId, const RsGxsCircleId &circleId, const RsGxsId &gxsId, const uint32_t type);
 	virtual ~GxsCircleItem();
 
-    QString uniqueIdentifier() const override;
+    std::string uniqueIdentifier() const override;
 	void loadRequest(const TokenQueue *queue, const TokenRequest &req);
 
 

retroshare-gui/src/gui/feeds/GxsForumGroupItem.h

@@ -42,7 +42,7 @@ public:
 
 	bool setGroup(const RsGxsForumGroup &group);
 
-    virtual QString uniqueIdentifier() const override { return "GxsForumGroupItem " + QString::fromStdString(mGroup.mMeta.mGroupId.toStdString()) ; }
+    virtual std::string uniqueIdentifier() const override { return "GxsForumGroupItem " + mGroup.mMeta.mGroupId.toStdString() ; }
 protected:
 	/* FeedItem */
 	virtual void doExpand(bool open);

retroshare-gui/src/gui/feeds/GxsForumMsgItem.h

@@ -43,7 +43,7 @@ public:
 	bool setGroup(const RsGxsForumGroup &group, bool doFill = true);
 	bool setMessage(const RsGxsForumMsg &msg, bool doFill = true);
 
-    QString uniqueIdentifier() const override { return "GxsForumMsgItem " + QString::fromStdString(mMessage.mMeta.mMsgId.toStdString()) ; }
+    std::string uniqueIdentifier() const override { return "GxsForumMsgItem " + mMessage.mMeta.mMsgId.toStdString() ; }
 protected:
 	/* FeedItem */
 	virtual void doExpand(bool open);

retroshare-gui/src/gui/feeds/MsgItem.h

@@ -38,7 +38,7 @@ public:
 
 	void updateItemStatic();
 
-    virtual QString uniqueIdentifier() const override { return "MsgItem " + QString::fromStdString(mMsgId) ; }
+    virtual std::string uniqueIdentifier() const override { return "MsgItem " + mMsgId ; }
 protected:
 	/* FeedItem */
 	virtual void doExpand(bool open);

retroshare-gui/src/gui/feeds/PeerItem.cpp

@@ -67,9 +67,9 @@ PeerItem::PeerItem(FeedHolder *parent, uint32_t feedId, const RsPeerId &peerId,
     updateItem();
 }
 
-QString PeerItem::uniqueIdentifier() const
+std::string PeerItem::uniqueIdentifier() const
 {
-    return "PeerItem " + QString::fromStdString(mPeerId.toStdString()) + " " + QString::number(mType) ;
+    return "PeerItem " + mPeerId.toStdString() + " " + QString::number(mType).toStdString() ;
 }
 
 void PeerItem::updateItemStatic()

retroshare-gui/src/gui/feeds/PeerItem.h

@@ -43,7 +43,7 @@ public:
 
 	void updateItemStatic();
 
-    virtual QString uniqueIdentifier() const;
+    std::string uniqueIdentifier() const override;
 
 protected:
 	/* FeedItem */

retroshare-gui/src/gui/feeds/PostedGroupItem.h

@@ -42,7 +42,7 @@ public:
 
 	bool setGroup(const RsPostedGroup &group);
 
-    virtual QString uniqueIdentifier() const override { return "PostedGroupItem " + QString::fromStdString(mGroup.mMeta.mGroupId.toStdString()) ; }
+    virtual std::string uniqueIdentifier() const override { return "PostedGroupItem " + mGroup.mMeta.mGroupId.toStdString() ; }
 
 protected:
 	/* FeedItem */

retroshare-gui/src/gui/feeds/SecurityIpItem.cpp

@@ -78,10 +78,9 @@ void SecurityIpItem::setup()
 	updateItem();
 }
 
-QString SecurityIpItem::uniqueIdentifier() const
+std::string SecurityIpItem::uniqueIdentifier() const
 {
-    return "SecurityItem " + QString::number(mType) + " " + QString::fromStdString(mSslId.toStdString())
+    return "SecurityItem " + QString::number(mType).toStdString() + " " + mSslId.toStdString() + " " + mIpAddr + " " + mIpAddrReported ;
-            + " " + QString::fromStdString(mIpAddr) + " " + QString::fromStdString(mIpAddrReported) ;
 }
 
 void SecurityIpItem::updateItemStatic()

retroshare-gui/src/gui/feeds/SecurityIpItem.h

@@ -43,7 +43,7 @@ public:
 
 	void updateItemStatic();
 
-    QString uniqueIdentifier() const override;
+    std::string uniqueIdentifier() const override;
 
 protected:
 	/* FeedItem */

retroshare-gui/src/gui/feeds/SecurityItem.cpp

@@ -81,9 +81,9 @@ SecurityItem::SecurityItem(FeedHolder *parent, uint32_t feedId, const RsPgpId &g
 	updateItem();
 }
 
-QString SecurityItem::uniqueIdentifier() const
+std::string SecurityItem::uniqueIdentifier() const
 {
-    return "SecurityItem " + QString::number(mType) + " " + QString::fromStdString(mSslId.toStdString());
+    return "SecurityItem " + QString::number(mType).toStdString() + " " + mSslId.toStdString();
 }
 
 void SecurityItem::updateItemStatic()

retroshare-gui/src/gui/feeds/SecurityItem.h

@@ -42,7 +42,7 @@ public:
 
 	void updateItemStatic();
 
-    QString uniqueIdentifier() const override;
+    std::string uniqueIdentifier() const override;
 
 protected:
 	/* FeedItem */