Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2024-10-01 02:35:48 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix CppCheck in p3filelists.cc

Browse Source 
/libretroshare/src/file_sharing/hash_cache.h:57: warning:
Cppcheck(noExplicitConstructor): Class 'HashStorage' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/file_sharing/p3filelists.cc:375: warning:
Cppcheck(unusedVariable): Unused variable: mit
/libretroshare/src/file_sharing/p3filelists.cc:1530: warning:
Cppcheck(unreadVariable): Variable 'indent' is assigned a value that is
never used.
This commit is contained in:
Phenom 2017-07-21 12:43:06 +02:00 committed by csoler
parent d9965acf1d
commit 0e014d6632
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libretroshare/src/file_sharing/p3filelists.cc
View File

@ -437,14 +437,14 @@ bool p3FileDatabase::loadList(std::list<RsItem *>& load)
if (NULL != (rskv = dynamic_cast<RsConfigKeyValueSet *>(*it))) if (NULL != (rskv = dynamic_cast<RsConfigKeyValueSet *>(*it)))
{ {
/* make into map */ /* make into map */
std::map<std::string, std::string> configMap; //std::map<std::string, std::string> configMap;
std::map<std::string, std::string>::const_iterator mit ; //std::map<std::string, std::string>::const_iterator mit ;
for(std::list<RsTlvKeyValue>::const_iterator kit = rskv->tlvkvs.pairs.begin(); kit != rskv->tlvkvs.pairs.end(); ++kit) for(std::list<RsTlvKeyValue>::const_iterator kit = rskv->tlvkvs.pairs.begin(); kit != rskv->tlvkvs.pairs.end(); ++kit)
if (kit->key == HASH_CACHE_DURATION_SS) if (kit->key == HASH_CACHE_DURATION_SS)
{ {
uint32_t t=0 ; uint32_t t=0 ;
if(sscanf(kit->value.c_str(),"%d",&t) == 1) if(sscanf(kit->value.c_str(),"%u",&t) == 1)
mHashCache->setRememberHashFilesDuration(t); mHashCache->setRememberHashFilesDuration(t);
} }
else if(kit->key == WATCH_FILE_DURATION_SS) else if(kit->key == WATCH_FILE_DURATION_SS)
@ -1744,7 +1744,7 @@ void p3FileDatabase::locked_recursSweepRemoteDirectory(RemoteDirectoryStorage *r
{ {
time_t now = time(NULL) ; time_t now = time(NULL) ;
std::string indent(2*depth,' ') ; //std::string indent(2*depth,' ') ;
// if not up to date, request update, and return (content is not certified, so no need to recurs yet). // if not up to date, request update, and return (content is not certified, so no need to recurs yet).
// if up to date, return, because TS is about the last modif TS below, so no need to recurs either. // if up to date, return, because TS is about the last modif TS below, so no need to recurs either.