Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-08-19 03:18:15 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed a big memory leak in hash cache storage load code, and improved deletion of allocated memory if file reading fails

Browse source
This commit is contained in:
csoler 2017-01-31 20:07:00 +01:00
parent 7861b092c3
commit 0a02419a29
3 changed files with 43 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

12
libretroshare/src/file_sharing/filelist_io.cc
View file

@ -59,16 +59,16 @@ bool FileListIO::writeField( unsigned char*&buff,uint32_t& buff_size,uint32
bool FileListIO::readField (const unsigned char *buff,uint32_t buff_size,uint32_t& offset,uint8_t check_section_tag, unsigned char *& val,uint32_t& size)
{
if(!readSectionHeader(buff,buff_size,offset,check_section_tag,size))
uint32_t local_size ;
if(!readSectionHeader(buff,buff_size,offset,check_section_tag,local_size))
return false;
val = (unsigned char *)rs_malloc(size) ;
if(!val)
if(!checkSectionSize(val,size,0,local_size)) // allocate val if needed to handle local_size bytes.
return false;
memcpy(val,&buff[offset],size);
offset += size ;
memcpy(val,&buff[offset],local_size);
offset += local_size ;
return true ;
}