Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-06-07 06:02:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed uninitialized memory read in GxsTrans msg Id

Browse source
This commit is contained in:
csoler 2017-05-28 22:49:07 +02:00
parent 6d76624e91
commit 0868b64436
3 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libretroshare/src/gxs/gxssecurity.cc
View file

@ -359,7 +359,7 @@ bool GxsSecurity::getSignature(const char *data, uint32_t data_len, const RsTlvP
ok &= EVP_SignUpdate(mdctx, data, data_len) == 1; ok &= EVP_SignUpdate(mdctx, data, data_len) == 1;
unsigned int siglen = EVP_PKEY_size(key_priv); unsigned int siglen = EVP_PKEY_size(key_priv);
unsigned char sigbuf[siglen]; unsigned char sigbuf[siglen] = { 0 };
ok &= EVP_SignFinal(mdctx, sigbuf, &siglen, key_priv) == 1; ok &= EVP_SignFinal(mdctx, sigbuf, &siglen, key_priv) == 1;
// clean up // clean up

3
libretroshare/src/gxstrans/p3gxstrans.cc
View file

@ -87,7 +87,10 @@ bool p3GxsTrans::sendData( RsGxsTransId& mailId,
} }
OutgoingRecord pr( recipient, service, data, size ); OutgoingRecord pr( recipient, service, data, size );
pr.mailItem.clear();
pr.mailItem.meta.mAuthorId = own_gxsid; pr.mailItem.meta.mAuthorId = own_gxsid;
pr.mailItem.meta.mMsgId.clear();
pr.mailItem.cryptoType = cm; pr.mailItem.cryptoType = cm;
pr.mailItem.mailId = RSRandom::random_u64(); pr.mailItem.mailId = RSRandom::random_u64();

2
libretroshare/src/pqi/authssl.cc
View file

@ -599,7 +599,7 @@ bool AuthSSLimpl::SignData(const void *data, const uint32_t len, std::string &si
EVP_MD_CTX *mdctx = EVP_MD_CTX_create(); EVP_MD_CTX *mdctx = EVP_MD_CTX_create();
unsigned int signlen = EVP_PKEY_size(mOwnPrivateKey); unsigned int signlen = EVP_PKEY_size(mOwnPrivateKey);
unsigned char signature[signlen]; unsigned char signature[signlen] = { 0 };
if (0 == EVP_SignInit(mdctx, EVP_sha1())) if (0 == EVP_SignInit(mdctx, EVP_sha1()))
{ {