From 7f05a4fd9f27ce057a4f710466a61f852c26b9eb Mon Sep 17 00:00:00 2001
From: "jacob.eva" <x00010@disroot.org>
Date: Wed, 21 Aug 2024 17:54:38 +0100
Subject: [PATCH] Fix weird behaviour with queue sizing

---
 RNode_Firmware_CE.ino | 6 +++---
 Utilities.h           | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/RNode_Firmware_CE.ino b/RNode_Firmware_CE.ino
index dabe7c9..639afda 100644
--- a/RNode_Firmware_CE.ino
+++ b/RNode_Firmware_CE.ino
@@ -137,7 +137,7 @@ void setup() {
   for (int i = 0; i < INTERFACE_COUNT; i++) {
       fifo16_init(&packet_starts[i], packet_starts_buf, CONFIG_QUEUE_MAX_LENGTH);
       fifo16_init(&packet_lengths[i], packet_lengths_buf, CONFIG_QUEUE_MAX_LENGTH);
-      packet_queue[i] = (uint8_t*)malloc(getQueueSize(i));
+      packet_queue[i] = (uint8_t*)malloc(getQueueSize(i)+1);
   }
 
   // Create and configure interface objects
@@ -585,9 +585,9 @@ void serialCallback(uint8_t sbyte) {
 
     if (getInterfaceIndex(command) < INTERFACE_COUNT) {
             uint8_t index = getInterfaceIndex(command);
-        if (!fifo16_isfull(&packet_starts[index]) && queued_bytes[index] < (getQueueSize(index))) {
+        if (!fifo16_isfull(&packet_starts[index]) && (queued_bytes[index] < (getQueueSize(index)))) {
             uint16_t s = current_packet_start[index];
-            int16_t e = queue_cursor[index]-1; if (e == -1) e = (getQueueSize(index))-1;
+            uint16_t e = queue_cursor[index]-1; if (e == -1) e = (getQueueSize(index))-1;
             uint16_t l;
 
             if (s != e) {
diff --git a/Utilities.h b/Utilities.h
index 2d82b15..95def2f 100644
--- a/Utilities.h
+++ b/Utilities.h
@@ -1100,7 +1100,7 @@ uint8_t getInterfaceCommandByte(uint8_t index) {
     }
 }
 
-uint32_t getQueueSize(uint8_t index) {
+uint16_t getQueueSize(uint8_t index) {
     switch (index) {
         case 0:
             return CONFIG_QUEUE_0_SIZE;