mirror of
https://github.com/Divested-Mobile/DivestOS-Build.git
synced 2024-10-01 01:35:54 -04:00
38 lines
1.4 KiB
Diff
38 lines
1.4 KiB
Diff
From 83af063d6dec0439eb5abf3b19df2b4990e88e86 Mon Sep 17 00:00:00 2001
|
|
From: Lars-Peter Clausen <lars@metafoo.de>
|
|
Date: Thu, 14 Apr 2016 17:01:17 +0200
|
|
Subject: [PATCH] BACKPORT: usb: gadget: f_fs: Fix use-after-free
|
|
|
|
(cherry picked from commit 38740a5b87d53ceb89eb2c970150f6e94e00373a)
|
|
|
|
When using asynchronous read or write operations on the USB endpoints the
|
|
issuer of the IO request is notified by calling the ki_complete() callback
|
|
of the submitted kiocb when the URB has been completed.
|
|
|
|
Calling this ki_complete() callback will free kiocb. Make sure that the
|
|
structure is no longer accessed beyond that point, otherwise undefined
|
|
behaviour might occur.
|
|
|
|
Fixes: 2e4c7553cd6f ("usb: gadget: f_fs: add aio support")
|
|
Cc: <stable@vger.kernel.org> # v3.15+
|
|
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
|
|
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
|
|
Change-Id: I3c7b643f6440c4fb6160a57c1058523030b46a6c
|
|
Bug: 30950866
|
|
---
|
|
drivers/usb/gadget/function/f_fs.c | 1 -
|
|
1 file changed, 1 deletion(-)
|
|
|
|
diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
|
|
index e389c27d8e202..599a4273d29d4 100644
|
|
--- a/drivers/usb/gadget/function/f_fs.c
|
|
+++ b/drivers/usb/gadget/function/f_fs.c
|
|
@@ -689,7 +689,6 @@ static void ffs_user_copy_worker(struct work_struct *work)
|
|
|
|
usb_ep_free_request(io_data->ep, io_data->req);
|
|
|
|
- io_data->kiocb->private = NULL;
|
|
if (io_data->read)
|
|
kfree(io_data->iovec);
|
|
kfree(io_data->buf);
|