From de2ba147b18528eda7ee943865f8569823fbf3f9 Mon Sep 17 00:00:00 2001 From: Daniel Micay Date: Wed, 23 Nov 2016 16:04:50 -0500 Subject: [PATCH] Add optional automated signing Change-Id: If5a888f12764c4928f5efbb2fda78f76fb445a2a --- core/Makefile | 43 +++++++++++++++++++++++++++++++++++++------ 1 file changed, 37 insertions(+), 6 deletions(-) diff --git a/core/Makefile b/core/Makefile index 1d6bff0..d65fd27 100644 --- a/core/Makefile +++ b/core/Makefile @@ -418,6 +418,11 @@ ifneq ($(OTA_PACKAGE_SIGNING_KEY),) DEFAULT_KEY_CERT_PAIR := $(OTA_PACKAGE_SIGNING_KEY) endif +ifneq ($(SIGNING_KEY_DIR),) + KEY_CERT_DIR := $(SIGNING_KEY_DIR) + DEFAULT_KEY_CERT_PAIR := $(SIGNING_KEY_DIR)/releasekey +endif + # Rules that need to be present for the all targets, even # if they don't do anything. .PHONY: systemimage @@ -1030,11 +1035,15 @@ endif # substitute other keys for this one. OTA_PUBLIC_KEYS := $(DEFAULT_SYSTEM_DEV_CERTIFICATE).x509.pem -ifneq ($(OTA_PACKAGE_SIGNING_KEY),) - OTA_PUBLIC_KEYS := $(OTA_PACKAGE_SIGNING_KEY).x509.pem - PRODUCT_EXTRA_RECOVERY_KEYS := $(DEFAULT_SYSTEM_DEV_CERTIFICATE) +ifneq ($(SIGNING_KEY_DIR),) + OTA_PUBLIC_KEYS := $(SIGNING_KEY_DIR)/releasekey.x509.pem + PRODUCT_EXTRA_RECOVERY_KEYS += $(SIGNING_KEY_DIR)/extra +else + ifneq ($(OTA_PACKAGE_SIGNING_KEY),) + OTA_PUBLIC_KEYS := $(OTA_PACKAGE_SIGNING_KEY).x509.pem + PRODUCT_EXTRA_RECOVERY_KEYS := $(DEFAULT_SYSTEM_DEV_CERTIFICATE) + endif endif - # Generate a file containing the keys that will be read by the # recovery binary. RECOVERY_INSTALL_OTA_KEYS := \ @@ -1818,6 +1827,13 @@ $(BUILT_TARGET_FILES_PACKAGE): intermediates := $(intermediates) $(BUILT_TARGET_FILES_PACKAGE): \ zip_root := $(intermediates)/$(name) +SIGNED_TARGET_FILES_PACKAGE := $(intermediates)/signed-$(name).zip +MAYBE_SIGNED_TARGET_FILES_PACKAGE := $(BUILT_TARGET_FILES_PACKAGE) + +ifneq ($(SIGNING_KEY_DIR),) + MAYBE_SIGNED_TARGET_FILES_PACKAGE := $(SIGNED_TARGET_FILES_PACKAGE) +endif + # $(1): Directory to copy # $(2): Location to copy it to # The "ls -A" is to prevent "acp s/* d" from failing if s is empty. @@ -2182,6 +2198,12 @@ else OTA_FROM_TARGET_SCRIPT := $(TARGET_RELEASETOOL_OTA_FROM_TARGET_SCRIPT) endif +ifeq ($(TARGET_RELEASETOOL_SIGN_TARGET_SCRIPT),) + SIGN_TARGET_SCRIPT := ./build/tools/releasetools/sign_target_files_apks +else + SIGN_TARGET_SCRIPT := $(TARGET_RELEASETOOL_SIGN_TARGET_SCRIPT) +endif + ifeq ($(WITH_GMS),true) $(INTERNAL_OTA_PACKAGE_TARGET): backuptool := false else @@ -2209,7 +2231,16 @@ ifneq ($(BLOCK_BASED_OTA),false) $(INTERNAL_OTA_PACKAGE_TARGET): block_based := --block endif -$(INTERNAL_OTA_PACKAGE_TARGET): $(BUILT_TARGET_FILES_PACKAGE) +$(SIGNED_TARGET_FILES_PACKAGE): $(BUILT_TARGET_FILES_PACKAGE) $(DISTTOOLS) + @echo "$(SIGN_TARGET_SCRIPT)" > $(PRODUCT_OUT)/sign_script_path + @echo -e ${CL_YLW}"Sign target files:"${CL_RST}" $@" + $(hide) $(SIGN_TARGET_SCRIPT) \ + -d $(KEY_CERT_DIR) \ + -o \ + $(BUILT_TARGET_FILES_PACKAGE) \ + $(SIGNED_TARGET_FILES_PACKAGE) + +$(INTERNAL_OTA_PACKAGE_TARGET): $(MAYBE_SIGNED_TARGET_FILES_PACKAGE) $(DISTTOOLS) @echo "$(OTA_FROM_TARGET_SCRIPT)" > $(PRODUCT_OUT)/ota_script_path @echo "$(override_device)" > $(PRODUCT_OUT)/ota_override_device @echo "Package OTA: $@" @@ -2221,7 +2252,7 @@ $(INTERNAL_OTA_PACKAGE_TARGET): $(BUILT_TARGET_FILES_PACKAGE) --backup=$(backuptool) \ --override_device=$(override_device) $(override_prop) \ $(if $(OEM_OTA_CONFIG), -o $(OEM_OTA_CONFIG)) \ - $(BUILT_TARGET_FILES_PACKAGE) $@ + $(MAYBE_SIGNED_TARGET_FILES_PACKAGE) $@ CM_TARGET_PACKAGE := $(PRODUCT_OUT)/cm-$(CM_VERSION).zip -- 2.9.3