when using strict (i.e set -e added by this PR) a build will fail on release when there is no recovery.img. this makes that non-fatal allowing to proceed
Signed-off-by: steadfasterX <steadfasterX@users.noreply.github.com>
this commit adds (the currently non-existing) error handling when
using divest's functions and scripts.
all the magic here gets activated when `source ../../Scripts/init.sh`
gets executed which is already a mandatory step before starting any
of the divest functions.
when something fails during patching, resetting or building
each error will be catched + printed including an error code now.
last but not least the executed file and the line number causing that
failure will be shown, too.
as all divest functions get source'd and so not a single build
script gets executed all ERR's needs to be trapped to catch issues.
I am not aware of another way to handle that properly as sourcing
means we cannot track a script or smth while this approach here
just works.
Example for an error thrown in a function call:
> ERROR: $DOS_WORKSPACE_ROOT/Scripts/Common/Functions.sh -> verifyAllPlatformTags() ended with status >1< at line >49<
Final SUCCESS result message after using `patchWorkspace`:
> [FINAL RESULT] No error detected (please check the above output nevertheless!)
Final ERROR result message after using `patchWorkspace`:
> [FINAL RESULT] Serious error(s) found!!!
> Summary error code was: 126. Check & fix all error lines above
Some notes:
- when an error occurs the process continues until the end (like it is now)
i.e. an error will not stop the current and following tasks
- when multiple errors occur the exit codes will be summed
- buildDevice: a (summed) end result gets printed (SUCCESS or ERROR) at the very end
- the trap used to catch any error will also be active for any command executed
on the cli. that means: type "false" -> ENTER and you will get an error, too
same for any script exectued after source init.sh
- when all goes well the trap will be resetted at the end but there are cases
where this might not happen -> that is why `resetEnv` can be executed to
reset the trap, i.e. all becomes as it was before sourcing init.sh
- `resetEnv` gets called automatically:
- after a successful `patchWorkspace` run
- whenever CTRL+C is used (during a running task or just on the cli)
- a process get killed (SIGHUP, TERM)
- the whole implementation might not catch all errors though - it highly depends
on how the function or the script/program called actually handles errors or better
said: if they return a proper exit code on failures.
For example some tools (like some git cmds) might print an error but don't return
a non-zero exit code. This cannot be tracked other then with your eyes or these
must be replaced by other methods returning a non-zero exit code on failures.
Signed-off-by: steadfasterX <steadfasterX@gmail.com>
Fixes the following issue on systems where /bin/sh != /bin/bash (e.g. Ubuntu):
> source [...]/Scripts/Common/Tag_Verifier.sh && verifyTagIfPlatform : 1: source: not found
for these (unsupported) systems the following is still required (not needed on Fedora or other systems using /bin/sh -> /bin/bash):
1. `ln -s /bin/bash ~/.local/bin/sh`
2. .bashrc -> `export PATH="$HOME/.local/bin:$PATH"`
3. .bashrc -> `alias sh='/bin/bash'`
Signed-off-by: steadfasterX <steadfasterX@users.noreply.github.com>
- 18.1: Fix exempted background tasks when dozing (GrapheneOS)
- 20.0: pick a fix for some colors after qpr2
- 20.0: fix the missing notification backdrop
Signed-off-by: Tad <tad@spotco.us>
- 18.1+: Disable NTP fully when automatic time is off, credit GrapheneOS
- 20.0: Handle Tor-over-Orbot when killswitch enabled, credit CalyxOS, BROKEN
Signed-off-by: Tad <tad@spotco.us>
Some devices still don't have these in 2023
https://gitlab.com/LineageOS/issues/android/-/issues/2193
Note, the following still aren't patched:
15.1
kernel/google/msm
kernel/lge/hammerhead
16.0
kernel/cyanogen/msm8974
kernel/lge/hammerhead
18.1
kernel/motorola/msm8974
Signed-off-by: Tad <tad@spotco.us>
Backports of rfc4941bis from Google/Linaro
and workaround for legacy kernels from GrapheneOS
already has rfc4941bis patch:
fairphone_sdm632
google_gs101
google_gs201
google_msm-4.14
google_msm-4.9
google_redbull
oneplus_sdm845
razer_sdm845
xiaomi_sdm845
Signed-off-by: Tad <tad@spotco.us>
