2017-11-07 18:55:10 -05:00
|
|
|
From e2addf5aa2c7dfc537c2b80d8cc1cb5640346535 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Amarnath Hullur Subramanyam <amarnath@codeaurora.org>
|
|
|
|
Date: Wed, 28 Oct 2015 21:07:47 -0700
|
2017-11-07 17:32:46 -05:00
|
|
|
Subject: wlan:Check priviledge permission for SET_BAND_CONFIG IOCTL
|
|
|
|
|
|
|
|
Kernel assumes all SET IOCTL commands are assigned with even
|
|
|
|
numbers. But in our WLAN driver, some SET IOCTLS are assigned with
|
|
|
|
odd numbers. This leads kernel fail to check, for some SET IOCTLs,
|
|
|
|
whether user has the right permission to do SET operation.
|
|
|
|
Hence, in driver, before processing SET_BAND_CONFIG IOCTL, making
|
|
|
|
sure user task has right permission to process the command.
|
|
|
|
|
|
|
|
CRs-Fixed: 930952
|
2017-11-07 18:55:10 -05:00
|
|
|
Git-commit: 6642bccf3ed8cba176dee7d4bbc21fc4580efb7b
|
|
|
|
Bug: 25344453
|
|
|
|
Signed-off-by: Amarnath Hullur Subramanyam <amarnath@codeaurora.org>
|
2017-11-07 17:32:46 -05:00
|
|
|
---
|
2017-11-07 18:55:10 -05:00
|
|
|
drivers/staging/qcacld-2.0/CORE/HDD/src/wlan_hdd_wext.c | 6 ++++++
|
2017-11-07 17:32:46 -05:00
|
|
|
1 file changed, 6 insertions(+)
|
|
|
|
|
2017-11-07 18:55:10 -05:00
|
|
|
diff --git a/drivers/staging/qcacld-2.0/CORE/HDD/src/wlan_hdd_wext.c b/drivers/staging/qcacld-2.0/CORE/HDD/src/wlan_hdd_wext.c
|
|
|
|
index 09d7288..1cbdf32 100644
|
|
|
|
--- a/drivers/staging/qcacld-2.0/CORE/HDD/src/wlan_hdd_wext.c
|
|
|
|
+++ b/drivers/staging/qcacld-2.0/CORE/HDD/src/wlan_hdd_wext.c
|
|
|
|
@@ -9417,6 +9417,12 @@ static int iw_set_band_config(struct net_device *dev,
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
2017-11-07 17:32:46 -05:00
|
|
|
|
|
|
|
+ if (!capable(CAP_NET_ADMIN)) {
|
|
|
|
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
|
|
|
|
+ FL("permission check failed"));
|
|
|
|
+ return -EPERM;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
return hdd_setBand(dev, value[0]);
|
|
|
|
}
|
|
|
|
|
|
|
|
--
|
|
|
|
cgit v1.1
|
|
|
|
|