2023-12-07 00:16:40 -05:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2023-12-07 00:07:00 -05:00
|
|
|
From: balakrishna <quic_kunthumu@quicinc.com>
|
|
|
|
|
Date: Wed, 24 May 2023 13:28:21 +0530
|
|
|
|
|
Subject: [PATCH] Fix OOB Write in pin_reply in bluetooth.cc
|
|
|
|
|
|
|
|
|
|
Root cause:
|
|
|
|
|
if the length of "pin_code" is greater than 16,
|
|
|
|
|
an OOBW will be triggered due to a missing bounds check.
|
|
|
|
|
|
|
|
|
|
Fix:
|
|
|
|
|
Check is added to avoid Out of Bound Write.
|
|
|
|
|
|
|
|
|
|
CRs-Fixed: 3507292
|
|
|
|
|
Change-Id: I15a1eae59b17f633e29180a01676c260189b8353
|
|
|
|
|
---
|
|
|
|
|
btif/src/bluetooth.c | 2 ++
|
|
|
|
|
1 file changed, 2 insertions(+)
|
|
|
|
|
|
|
|
|
|
diff --git a/btif/src/bluetooth.c b/btif/src/bluetooth.c
|
2023-12-07 00:16:40 -05:00
|
|
|
index b6552e251..121ad7314 100644
|
2023-12-07 00:07:00 -05:00
|
|
|
--- a/btif/src/bluetooth.c
|
|
|
|
|
+++ b/btif/src/bluetooth.c
|
2023-12-07 00:16:40 -05:00
|
|
|
@@ -346,6 +346,8 @@ static int pin_reply(const bt_bdaddr_t *bd_addr, uint8_t accept,
|
2023-12-07 00:07:00 -05:00
|
|
|
/* sanity check */
|
|
|
|
|
if (interface_ready() == FALSE)
|
|
|
|
|
return BT_STATUS_NOT_READY;
|
|
|
|
|
+ if (pin_code == NULL || pin_len > PIN_CODE_LEN)
|
|
|
|
|
+ return BT_STATUS_FAIL;
|
|
|
|
|
|
2023-12-07 00:16:40 -05:00
|
|
|
memcpy(&tmp_pin_code, pin_code, pin_len);
|
|
|
|
|
return btif_dm_pin_reply(bd_addr, accept, pin_len, &tmp_pin_code);
|
