From d87ca8f2af2458e8b57b1ec9915c72a4ca5ca19f Mon Sep 17 00:00:00 2001
From: oobabooga <112222186+oobabooga@users.noreply.github.com>
Date: Wed, 26 Apr 2023 03:47:34 -0300
Subject: [PATCH] LLaVA fixes

---
 extensions/llava/script.py | 6 +++---
 models/config.yaml         | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/extensions/llava/script.py b/extensions/llava/script.py
index ba951f20..9d44a2b0 100644
--- a/extensions/llava/script.py
+++ b/extensions/llava/script.py
@@ -205,11 +205,11 @@ def custom_generate_chat_prompt(user_input, state, **kwargs):
         if _continue and i == len(shared.history['internal']) - 1:
             rows.insert(1, f"{prefix2}{shared.history['internal'][i][1]}")
         else:
-            rows.insert(1, f"{prefix2}{shared.history['internal'][i][1].strip()}{state['end_of_turn']}\n")
+            rows.insert(1, f"{prefix2}{shared.history['internal'][i][1].strip()}\n")
 
         string = shared.history['internal'][i][0]
         if string != '':
-            rows.insert(1, f"{prefix1}{string.strip()}{state['end_of_turn']}\n")
+            rows.insert(1, f"{prefix1}{string.strip()}\n")
 
         i -= 1
 
@@ -219,7 +219,7 @@ def custom_generate_chat_prompt(user_input, state, **kwargs):
     elif not _continue:
         # Adding the user message
         if len(user_input) > 0:
-            rows.append(f"{prefix1}{user_input}{state['end_of_turn']}\n")
+            rows.append(f"{prefix1}{user_input}\n")
 
         # Adding the Character prefix
         rows.append(apply_extensions("bot_prefix", f"{prefix2}"))
diff --git a/models/config.yaml b/models/config.yaml
index e43c1648..cdae3ea2 100644
--- a/models/config.yaml
+++ b/models/config.yaml
@@ -52,6 +52,7 @@ llama-[0-9]*b-4bit$:
   mode: 'instruct'
   model_type: 'llama'
   instruction_template: 'LLaVA'
+  custom_stopping_strings: '"\n###"'
 .*raven:
   mode: 'instruct'
   instruction_template: 'RWKV-Raven'